mrproliu commented on code in PR #188:
URL: https://github.com/apache/skywalking-go/pull/188#discussion_r1675785435
##########
plugins/mux/serve_interceptor.go:
##########
@@ -58,8 +61,23 @@ func (n *ServeHTTPInterceptor) AfterInvoke(invocation
operator.Invocation, resul
return nil
}
+func newWriterWrapper(rw interface{}) (*writerWrapper, error) {
+ writer := rw.(http.ResponseWriter)
+ hijacker, ok := rw.(http.Hijacker)
+ if !ok {
+ return nil, fmt.Errorf("http.ResponseWriter does not implement
http.Hijacker")
Review Comment:
You mean the framework not work? Then I think you need to set it as nil if
the cast check failure. And if the cast success, you need to call the original
hijack method. Right? Otherwise, your framework will still failure for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
