kezhenxu94 commented on code in PR #12525:
URL: https://github.com/apache/skywalking/pull/12525#discussion_r1714712346
##########
oap-server/server-query-plugin/debugging-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingHTTPHandler.java:
##########
@@ -176,10 +176,11 @@ public String queryBasicTraces(@Param("service") String
service,
@Param("pageNum") int pageNum,
@Param("pageSize") int pageSize
) {
- String serviceId = IDManager.ServiceID.buildId(service,
Layer.nameOf(serviceLayer).isNormal());
+ Optional<String> serviceId = service.map(
Review Comment:
Why change to `Optional<String> serviceLayer` and
`serviceLayer.orElseThrow()` if it’s required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
