wankai123 commented on code in PR #12525:
URL: https://github.com/apache/skywalking/pull/12525#discussion_r1714726648
##########
oap-server/server-query-plugin/debugging-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingHTTPHandler.java:
##########
@@ -160,8 +160,8 @@ public String execExpression(@Param("dumpDBRsp") boolean
dumpStorageRsp,
@SneakyThrows
@Get("/debugging/query/trace/queryBasicTraces")
- public String queryBasicTraces(@Param("service") String service,
- @Param("serviceLayer") String serviceLayer,
+ public String queryBasicTraces(@Param("service") Optional<String> service,
Review Comment:
The `serviceId/serviceInstanceId/endpointId` in the graphQL are optional,
the implement also can ignore them.
https://github.com/apache/skywalking-query-protocol/blob/6ed9a1bb96c1c753d3211e55995117c9617e4339/trace.graphqls#L37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
