lujiajing1126 commented on code in PR #720:
URL: https://github.com/apache/skywalking-java/pull/720#discussion_r1815969164
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java:
##########
@@ -252,6 +252,25 @@ public static class Profile {
public static int SNAPSHOT_TRANSPORT_BUFFER_SIZE = 500;
}
+ public static class AsyncProfiler {
+ /**
+ * If true, skywalking agent will enable profile when user create a
new async profiler task.
+ * Otherwise disable it.
+ */
+ public static boolean ACTIVE = true;
+
+ /**
+ * Max monitor time(second), if async profiler monitor time out of
limit, then stop it.
+ * default 1h.
+ */
+ public static int MAX_DURATION = 600;
+
+ /**
+ * jfr directory generated by async profiler
+ */
+ public static String OUTPUT_PATH = "";
Review Comment:
It seems we don't have any default value for the output path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
