lujiajing1126 commented on code in PR #720:
URL: https://github.com/apache/skywalking-java/pull/720#discussion_r1816091115
##########
apm-sniffer/config/agent.config:
##########
@@ -164,6 +164,12 @@ profile.duration=${SW_AGENT_PROFILE_DURATION:10}
profile.dump_max_stack_depth=${SW_AGENT_PROFILE_DUMP_MAX_STACK_DEPTH:500}
# Snapshot transport to backend buffer size
profile.snapshot_transport_buffer_size=${SW_AGENT_PROFILE_SNAPSHOT_TRANSPORT_BUFFER_SIZE:4500}
+# If true, skywalking agent will enable profile when user create a new
asyncprofile task. Otherwise disable it.
Review Comment:
Same suggestion for the configurations
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java:
##########
@@ -252,6 +252,25 @@ public static class Profile {
public static int SNAPSHOT_TRANSPORT_BUFFER_SIZE = 500;
}
+ public static class AsyncProfiler {
+ /**
+ * If true, skywalking agent will enable profile when user create a
new async profiler task.
+ * Otherwise disable it.
Review Comment:
```suggestion
* Otherwise it is disabled.
```
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java:
##########
@@ -252,6 +252,25 @@ public static class Profile {
public static int SNAPSHOT_TRANSPORT_BUFFER_SIZE = 500;
}
+ public static class AsyncProfiler {
+ /**
+ * If true, skywalking agent will enable profile when user create a
new async profiler task.
+ * Otherwise disable it.
+ */
+ public static boolean ACTIVE = true;
+
+ /**
+ * Max monitor time(second), if async profiler monitor time out of
limit, then stop it.
Review Comment:
```suggestion
* Max execution time(second) for the Async Profiler. The task will
be stopped even if a longer time is specified.
```
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java:
##########
@@ -252,6 +252,25 @@ public static class Profile {
public static int SNAPSHOT_TRANSPORT_BUFFER_SIZE = 500;
}
+ public static class AsyncProfiler {
+ /**
+ * If true, skywalking agent will enable profile when user create a
new async profiler task.
+ * Otherwise disable it.
+ */
+ public static boolean ACTIVE = true;
+
+ /**
+ * Max monitor time(second), if async profiler monitor time out of
limit, then stop it.
+ * default 1h.
+ */
+ public static int MAX_DURATION = 600;
+
+ /**
+ * jfr directory generated by async profiler
Review Comment:
```suggestion
* Path for the JFR outputs from the Async profiler
```
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java:
##########
@@ -252,6 +252,25 @@ public static class Profile {
public static int SNAPSHOT_TRANSPORT_BUFFER_SIZE = 500;
}
+ public static class AsyncProfiler {
+ /**
+ * If true, skywalking agent will enable profile when user create a
new async profiler task.
Review Comment:
```suggestion
* If true, Async Profiler will be enabled when user creates a new
async profiler task.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
