wu-sheng commented on code in PR #102:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/102#discussion_r1820161381
##########
asyncprofiler/AsyncProfiler.proto:
##########
@@ -44,11 +44,17 @@ message AsyncProfilerData {
}
}
+message AsyncProfilerCollectMessage {
+ AsyncProfilerCollectType type = 1;
+}
+
enum AsyncProfilerCollectType {
// PROFILING_SUCCESS means the Java Agent has finished the execution
PROFILING_SUCCESS = 0;
// EXECUTION_TASK_ERROR means potential execution error caused by the Java
Agent, such as an error in the sent task parameters.
Review Comment:
```suggestion
// EXECUTION_TASK_ERROR indicates a potential execution error caused by
the Java Agent, such as an error in the task parameters that were sent.
```
##########
asyncprofiler/AsyncProfiler.proto:
##########
@@ -44,11 +44,17 @@ message AsyncProfilerData {
}
}
+message AsyncProfilerCollectMessage {
+ AsyncProfilerCollectType type = 1;
+}
+
enum AsyncProfilerCollectType {
// PROFILING_SUCCESS means the Java Agent has finished the execution
Review Comment:
```suggestion
// PROFILING_SUCCESS indicates the Java Agent has finished the execution
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
