wu-sheng commented on code in PR #102:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/102#discussion_r1820160000
##########
asyncprofiler/AsyncProfiler.proto:
##########
@@ -44,11 +44,17 @@ message AsyncProfilerData {
}
}
+message AsyncProfilerCollectMessage {
+ AsyncProfilerCollectType type = 1;
+}
+
enum AsyncProfilerCollectType {
// PROFILING_SUCCESS means the Java Agent has finished the execution
PROFILING_SUCCESS = 0;
// EXECUTION_TASK_ERROR means potential execution error caused by the Java
Agent, such as an error in the sent task parameters.
EXECUTION_TASK_ERROR = 1;
+ // TERMINATED_BY_OVERSIZE means that the server cannot receive the jfr file
because it is too large.
Review Comment:
```suggestion
// TERMINATED_BY_OVERSIZE indicates that the server cannot receive the JFR
file because the size of the file is over the limitation.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
