zhengziyi0117 commented on code in PR #12671: URL: https://github.com/apache/skywalking/pull/12671#discussion_r1824645859
########## oap-server/server-receiver-plugin/skywalking-async-profiler-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/asyncprofiler/provider/handler/stream/AsyncProfilerFileCollectionObserver.java: ########## Review Comment: My idea here is to provide two solutions. The one is to use memory to receive jfr files without writing files (this is currently used). This can prevent the oap server from crashing due to no volume mounting. The other solution is this class, which uses createTemp to write files and then reads the files for parsing. The advantage of this is that it reduces memory and prevents the oap server from crashing due to insufficient memory, but it may report an error due to no volume mounting. I think a configuration can be added later for users to choose between these two solutions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
