zhengziyi0117 commented on code in PR #12671:
URL: https://github.com/apache/skywalking/pull/12671#discussion_r1824635914
##########
LICENSE:
##########
@@ -225,3 +225,4 @@ The text of each license is the standard Apache 2.0 license.
mvnw files from https://github.com/apache/maven-wrapper Apache 2.0
svg files from skywalking-ui/src/assets/icons:
https://github.com/google/material-design-icons Apache 2.0
ZipkinQueryHandler.java reference from
zipkin2.server.internal.ZipkinQueryApiV2: https://github.com/openzipkin/zipkin
Apache 2.0
+ async-profiler parser files in
server-library/library-async-profiler-jfr-parser from
https://github.com/open-telemetry/opentelemetry-proto/tree/v0.7.0 Apache 2.0
Review Comment:
I think this is a great solution, but I still have the following problems:
1. This package currently has some classes that I want to inherit that are
not public, and some code may still need to be copied (I will try my best to
solve this problem)
2. Some of the code in this package seems to be different from the current
`async-profiler convert 3.0`, so the switch is a bit complicated.
I will raise an issue later to solve these problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
