peachisai commented on code in PR #13119:
URL: https://github.com/apache/skywalking/pull/13119#discussion_r2005608584
##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/Analyzer.java:
##########
@@ -374,4 +374,17 @@ private void processRelationClientSide(MeterEntity entity)
{
MetricsStreamProcessor.getInstance().in(metrics);
}
+ public boolean filter(ImmutableMap<String, SampleFamily> sampleFamilies) {
+ if (filterExpression == null) {
+ return true;
+ }
+
+ for (Map.Entry<String, SampleFamily> entry :
sampleFamilies.entrySet()) {
+ if
(!filterExpression.filter(entry.getValue()).equals(SampleFamily.EMPTY)) {
+ return true;
+ }
+ }
Review Comment:
> For most cases, we use global available tags, but we can't guarantee that
is always the case.
In one metric convert, there is always global filter, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
