wu-sheng commented on code in PR #13119:
URL: https://github.com/apache/skywalking/pull/13119#discussion_r2007670244
##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/MetricConvert.java:
##########
@@ -127,4 +127,17 @@ private void handleInitExp(String exp) {
"failed to execute init expression: " + exp + ", error:" +
result.getError());
}
}
+
+ /**
+ * Because all analyzers share the same filter expression, we use one
analyzer to filter all sampleFamilies.
+ * If one SampleFamily passes the check, the process should continue. If
none of the sampleFamilies pass the filter,
+ * no further processing will be performed.
+ */
Review Comment:
```suggestion
/**
* Because all analyzers share the same filter expression, we do
pre-check to filter all SampleFamily(s).
* If one SampleFamily could pass the check, the process should
continue.
* Otherwise, no further processing will be performed.
* By this, we could improve the extra payload to do this filter check
repeatedly.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
