hanahmily commented on PR #642: URL: https://github.com/apache/skywalking-banyandb/pull/642#issuecomment-2803895543
@onkar717 The reloader seems good to me, although there are a few minor issues to address. Let's move on to the next test: Update https://github.com/apache/skywalking-banyandb/blob/main/test/integration/standalone/other/tls_test.go#L76. Add the following: `g.It("queries an updated TLS server")`. In the test function, please do the following: 1. Create new certificate and key files, similar to the existing ones. 2. Establish a new connection using these new files. 3. Finally, run the verification function as shown below: ```go gm.Eventually(func(innerGm gm.Gomega) { casesMeasureData.VerifyFn(innerGm, helpers.SharedContext{ Connection: conn, BaseTime: baseTime, }, helpers.Args{Input: "all", Duration: 25 * time.Minute, Offset: -20 * time.Minute}) }, flags.EventuallyTimeout).Should(gm.Succeed()) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
