hanahmily commented on code in PR #642:
URL:
https://github.com/apache/skywalking-banyandb/pull/642#discussion_r2046141350
##########
test/integration/standalone/other/tls_test.go:
##########
@@ -74,4 +77,79 @@ var _ = g.Describe("Query service_cpm_minute", func() {
}, helpers.Args{Input: "all", Duration: 25 *
time.Minute, Offset: -20 * time.Minute})
}, flags.EventuallyTimeout).Should(gm.Succeed())
})
+
+ g.It("queries an updated TLS server", func() {
Review Comment:
Please add a new test titled "Queries an Updated HTTP Server":
1. In the line "addr, _, deferFn = setup.StandaloneWithTLS", the second
returned value (which is ignored) represents the HTTP address.
2. You can utilize the [HTTP health
checker](https://github.com/apache/skywalking-banyandb/blob/main/pkg/test/helpers/http_health.go)
to verify the functionality of the HTTP server in this scenario.
3. The procedure should be the same as for the "Queries an Updated TLS
Server."
##########
banyand/liaison/http/server.go:
##########
@@ -69,6 +70,7 @@ type Server interface {
type server struct {
Review Comment:
`grpcCert` doesn't get loaded dynamically. The gRPC's cert helps the HTTP
gateway redirect requests to the gRPC server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
