OmCheeLin commented on code in PR #674:
URL:
https://github.com/apache/skywalking-banyandb/pull/674#discussion_r2109339845
##########
banyand/protector/protector.go:
##########
@@ -37,6 +37,21 @@ import (
var scope = observability.RootScope.SubScope("memory_protector")
+// MemoryProtector is an interface for monitoring and limiting memory usage to
prevent OOM.
+type MemoryProtector interface {
Review Comment:
If that's the case, we might have to change dozens of places from `pm
*protector.Memory` to `pm protector.Memory`. Do we really have to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
