hanahmily commented on code in PR #674:
URL:
https://github.com/apache/skywalking-banyandb/pull/674#discussion_r2110589081
##########
banyand/protector/protector.go:
##########
@@ -37,6 +37,21 @@ import (
var scope = observability.RootScope.SubScope("memory_protector")
+// MemoryProtector is an interface for monitoring and limiting memory usage to
prevent OOM.
+type MemoryProtector interface {
Review Comment:
Yes, the role of the interface is to conceal the structure. If you introduce
the interface, the exported structure no longer makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
