wu-sheng commented on code in PR #684:
URL:
https://github.com/apache/skywalking-banyandb/pull/684#discussion_r2156186787
##########
banyand/property/shard.go:
##########
@@ -80,11 +80,12 @@ func (db *database) newShard(ctx context.Context, id
common.ShardID, _ int64) (*
location: location,
}
opts := inverted.StoreOpts{
- Path: location,
- Logger: si.l,
- Metrics:
inverted.NewMetrics(db.omr.With(propertyScope.ConstLabels(meter.LabelPairs{"shard":
sName}))),
- BatchWaitSec: 0,
- PrepareMergeCallback: si.prepareForMerge,
+ Path: location,
+ Logger: si.l,
+ Metrics:
inverted.NewMetrics(db.omr.With(propertyScope.ConstLabels(meter.LabelPairs{"shard":
sName}))),
+ BatchWaitSec: 0,
+ PrepareMergeCallback: si.prepareForMerge,
+ MinSegmentsForInMemoryMerge: 1,
Review Comment:
Could we document this somewhere, as it is important for property type data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
