wu-sheng commented on code in PR #684:
URL:
https://github.com/apache/skywalking-banyandb/pull/684#discussion_r2156500956
##########
banyand/property/service.go:
##########
@@ -71,6 +72,7 @@ func (s *service) FlagSet() *run.FlagSet {
flagS.DurationVar(&s.flushTimeout, "property-flush-timeout",
defaultFlushTimeout, "the memory data timeout of measure")
flagS.IntVar(&s.maxDiskUsagePercent, "property-max-disk-usage-percent",
95, "the maximum disk usage percentage allowed")
flagS.IntVar(&s.maxFileSnapshotNum, "property-max-file-snapshot-num",
2, "the maximum number of file snapshots allowed")
+ flagS.DurationVar(&s.expireTimeout, "property-expire-delete-timeout",
time.Hour*24*7, "the duration of the expired data need to be deleted")
Review Comment:
```suggestion
flagS.DurationVar(&s.expireTimeout, "property-expire-delete-timeout",
time.Hour*24*7, "the duration of the expired data needs to be deleted")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
