youjie23 commented on PR #134: URL: https://github.com/apache/skywalking-infra-e2e/pull/134#issuecomment-3436532499
> That looks weird to me. Do we need to fix many test cases? Can we fix them with some script? After the GHA run, I've identified approximately 10 test cases that require modification and I suspect there might be more to it. On one hand, we could simply set the times value in all trigger configurations to a very high number. This would make the triggers run continuously throughout the entire end-to-end test verification period, behave as before. However, this adjustment seems a bit odd, doesn't it?? On the other hand, having the trigger run continuously is acceptable and works fine in other scenarios. The specific issue here is with the alert recovery detection scenario([#13539](https://github.com/apache/skywalking/pull/13539)). This scenario requires a defined recovery time window, meaning the trigger needs to stop after a certain number of runs to accurately assess recovery. Therefore, my proposal is to add a new configuration option to explicitly control whether the trigger stops after reaching the specified times value. This provides the necessary flexibility for the alert recovery use case without affecting other scenarios. Looking forward to your suggestions on this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
