kezhenxu94 commented on PR #134: URL: https://github.com/apache/skywalking-infra-e2e/pull/134#issuecomment-3436596334
The `times` is expected to control how many times the call should be triggered, the test case you mentioned worked before because of this bug, and since we fixed this bug we should adjust the test case instead of adding a new opposite config to make it work again. > On the other hand, having the trigger run continuously is acceptable and works fine in other scenarios. The specific issue here is with the alert recovery detection scenario(#13539). This scenario requires a defined recovery time window, meaning the trigger needs to stop after a certain number of runs to accurately assess recovery. > > I think we can set the times to a non-positive value like (-1 or 0) to indicate never stop (if this doesn't already exist). Instead of adding a config `stop-on-reach-times` that had been expected to work with the `times` field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
