Copilot commented on code in PR #49:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/49#discussion_r2727240371
##########
test/e2e/values.lifecycle.yaml:
##########
@@ -193,12 +193,34 @@ cluster:
enabled: true
progressFile: "/tmp/stream/lifecycle/progress.json"
reportDir: "/tmp/stream/lifecycle/reports"
+ resources:
Review Comment:
`lifecycleSidecar.resources` is being set using the list-of-`{key,value}`
format (matching `cluster.data.nodeTemplate.resources`), but the chart renders
sidecar resources via `toYaml` (see
`chart/templates/cluster_data_statefulset.yaml`), which expects standard
Kubernetes `resources` maps (e.g., `requests.cpu: 200m`). With the current list
format, the rendered StatefulSet will have an invalid `resources` shape and may
fail to apply. Please change this to the standard map form under
`requests`/`limits` (cpu/memory as keys).
##########
test/e2e/values.lifecycle.yaml:
##########
@@ -193,12 +193,34 @@ cluster:
enabled: true
progressFile: "/tmp/stream/lifecycle/progress.json"
reportDir: "/tmp/stream/lifecycle/reports"
+ resources:
+ requests:
+ - key: cpu
+ value: 200m
+ - key: memory
+ value: 128Mi
+ limits:
+ - key: cpu
+ value: 500m
+ - key: memory
+ value: 512Mi
warm:
lifecycleSidecar:
schedule: "@daily"
enabled: true
progressFile: "/tmp/stream/lifecycle/progress.json"
reportDir: "/tmp/stream/lifecycle/reports"
+ resources:
Review Comment:
Same issue as hot role: `lifecycleSidecar.resources` uses a
list-of-`{key,value}` entries, but the chart templates render sidecar
`resources` via `toYaml`, which requires the standard Kubernetes map structure
(`requests.cpu`, `limits.memory`, etc.). Update this block to a map-based
`resources` definition so the generated manifest is valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
