Copilot commented on code in PR #49:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/49#discussion_r2729996351
##########
chart/values.yaml:
##########
@@ -977,10 +977,12 @@ cluster:
resources:
## @param cluster.fodc.agent.resources.requests Resource requests for
Agent
requests:
- memory: 256Mi
+ - key: memory
+ value: 256Mi
## @param cluster.fodc.agent.resources.limits Resource limits for Agent
limits:
- memory: 256Mi
+ - key: memory
+ value: 256Mi
Review Comment:
`chart/values-lifecycle.yaml` still defines
`cluster.fodc.agent.resources.requests/limits` as a map (e.g., `memory:
256Mi`). With the updated templates expecting a list of `{key,value}` objects,
using `-f chart/values-lifecycle.yaml` will cause Helm rendering errors
(attempting to access `$request.key` on a map value). Update
`chart/values-lifecycle.yaml` to the same list format used in
`chart/values.yaml` for FODC agent (and proxy, if applicable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
