Siman-hub opened a new pull request, #787:
URL: https://github.com/apache/skywalking-java/pull/787
## Summary
This PR adds **Spring Cloud Gateway 4.3.3** to the `gateway-4.x-scenario`
test matrix.
## Compatibility Analysis
I verified source-level compatibility of `NettyRoutingFilter` in Gateway
`4.3.3` against the existing `v412x` plugin.
- **Structure change:** Gateway 4.3.3 introduces `getHttpClientMono`, which
is now invoked by the main `filter` flow.
- **Safety check:** The current implementation is eager:
```java
// org.springframework.cloud.gateway.filter.NettyRoutingFilter (v4.3.3)
protected Mono<HttpClient> getHttpClientMono(Route route, ServerWebExchange
exchange) {
return Mono.just(getHttpClient(route, exchange));
}
```
* Conclusion: Since Mono.just is evaluated immediately on the calling
thread, getHttpClient(...) (which SkyWalking instruments) is still executed
synchronously during request handling. Execution order and context propagation
remain unchanged, so the existing plugin continues to work as intended.
### Verification
- [x] Validated source compatibility (NettyRoutingFilter structure).
- [x] Validated binary compatibility (Plugin compiles against 4.3.3).
- [ ] Runtime verification delegated to CI (Local Windows environment
limitations prevented full Docker scenario execution).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
