Siman-hub commented on PR #787: URL: https://github.com/apache/skywalking-java/pull/787#issuecomment-3828015896
> > I’ve reverted the inclusion of Gateway 5.0.x from this PR. > > Reason: the current gateway-4.x-scenario is based on a Spring Boot 3.x environment, and Gateway 5.0.x seems to require a newer Spring Boot / Spring Framework baseline, which caused dependency resolution conflicts in the existing scenario. > > For now I’ll keep this PR focused on Gateway 4.3.3. > > I’m happy to follow up separately for Gateway 5.x — please let me know if introducing a dedicated gateway-5.x-scenario sounds like the right approach. > > It depends whether 5.x requires a new plugin implementation. If not, you could just add a new test scenario for 5.x, copy most of codes from here, and change Spring version to newer. Thanks for the guidance! I checked NettyRoutingFilter in Gateway 5.x and the main interception point (getHttpClient) still looks structurally similar to 4.x, so my current assumption is that the existing plugin might continue to work. I’ll follow your suggestion and add a separate gateway-5.x-scenario (copied from 4.x with upgraded Spring/Gateway versions) to validate runtime behavior. If I hit any incompatibilities requiring plugin changes, I’ll report back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
