Copilot commented on code in PR #51:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/51#discussion_r2762952958
##########
chart/templates/standalone_statefulset.yaml:
##########
@@ -248,7 +248,6 @@ spec:
- --proxy-addr={{ template "banyandb.fullname" .
}}-fodc-proxy-grpc:{{ .Values.cluster.fodc.proxy.grpcSvc.port }} \
- --pod-name=$(POD_NAME)
- --container-names=standalone
- - --node-role=standalone
- --poll-metrics-ports=2121
- --poll-metrics-interval={{
.Values.cluster.fodc.agent.config.pollMetricsInterval }}
Review Comment:
The standalone fodc-agent is missing the cluster-state-ports flag and
cluster-state-poll-interval flag that are being added to liaison and data
agents. Since the standalone container exposes port 17912 (gRPC) which provides
cluster state information, the fodc-agent should include these flags to monitor
cluster state. Consider adding:
- --cluster-state-ports=17912
- --cluster-state-poll-interval={{
.Values.cluster.fodc.agent.config.pollClusterStateInterval }}
```suggestion
- --poll-metrics-interval={{
.Values.cluster.fodc.agent.config.pollMetricsInterval }}
- --cluster-state-ports=17912
- --cluster-state-poll-interval={{
.Values.cluster.fodc.agent.config.pollClusterStateInterval }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
