hanahmily commented on code in PR #51:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/51#discussion_r2763085393
##########
chart/values.yaml:
##########
@@ -994,6 +994,8 @@ cluster:
reconnectInterval: 10s
## @param cluster.fodc.agent.config.ktmEnabled Enable Kernel Telemetry
Module (affects max-metrics-memory-usage-percentage)
ktmEnabled: true
+ ## @param cluster.fodc.agent.config.pollClusterStateInterval Interval
for polling cluster state from Proxy (poll-cluster-state-interval flag)
+ pollClusterStateInterval: 30s
Review Comment:
Update parameters.md since a new parameter has been introduced.
##########
chart/templates/standalone_statefulset.yaml:
##########
@@ -248,7 +248,6 @@ spec:
- --proxy-addr={{ template "banyandb.fullname" .
}}-fodc-proxy-grpc:{{ .Values.cluster.fodc.proxy.grpcSvc.port }} \
- --pod-name=$(POD_NAME)
- --container-names=standalone
- - --node-role=standalone
- --poll-metrics-ports=2121
- --poll-metrics-interval={{
.Values.cluster.fodc.agent.config.pollMetricsInterval }}
Review Comment:
It makes sense. Please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
