Copilot commented on code in PR #1155:
URL:
https://github.com/apache/skywalking-banyandb/pull/1155#discussion_r3354179413
##########
banyand/trace/metrics.go:
##########
@@ -26,8 +26,9 @@ import (
)
var (
- streamScope = observability.RootScope.SubScope("trace")
- tbScope = streamScope.SubScope("tst")
+ streamScope = observability.RootScope.SubScope("trace")
+ tbScope = streamScope.SubScope("tst")
+ storageScope = streamScope.SubScope("storage")
Review Comment:
`traceScope` is already defined in this package (trace.go) and is used for
other sub-scopes (e.g., `metadataScope`). Defining a second root scope here
(`streamScope = observability.RootScope.SubScope("trace")`) duplicates the
source of truth and could lead to inconsistent namespaces if one is ever
changed. Consider deriving `streamScope`, `tbScope`, and `storageScope` from
the existing `traceScope` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
