hanahmily commented on PR #1155: URL: https://github.com/apache/skywalking-banyandb/pull/1155#issuecomment-4619905087
Good catch, Copilot — addressed in commit 2c858562. Removed the duplicate `streamScope` declaration in `banyand/trace/metrics.go` and now derive `tbScope` and `storageScope` from the canonical `traceScope` already defined in `banyand/trace/trace.go:51`. The smoke test `TestStorageScopeNamespace` was updated to assert the `traceScope` namespace chain (`banyandb_trace` → `banyandb_trace_tst` / `banyandb_trace_storage`). `go test -short ./banyand/trace/` and `./banyand/internal/storage/...` both pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
