wu-sheng commented on a change in pull request #3761: Rabbitmq instrument
consumer class correctly to get duration reported…
URL: https://github.com/apache/skywalking/pull/3761#discussion_r341435723
##########
File path:
apm-sniffer/apm-sdk-plugin/rabbitmq-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/rabbitmq/define/RabbitMQConsumerInstrumentation.java
##########
@@ -71,6 +71,6 @@
@Override
protected ClassMatch enhanceClass() {
- return MultiClassNameMatch.byMultiClassMatch(ENHANCE_CLASS_PRODUCER);
+ return HierarchyMatch.byHierarchyMatch(new String[]
{ENHANCE_CLASS_PRODUCER}, true);
Review comment:
Yes. We don't recommend because of potential side effect. Such as someone
implement the interfaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
