wu-sheng commented on a change in pull request #3761: Rabbitmq instrument
consumer class correctly to get duration reported…
URL: https://github.com/apache/skywalking/pull/3761#discussion_r341812888
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/match/HierarchyMatch.java
##########
@@ -46,6 +47,11 @@ private HierarchyMatch(String[] parentTypes) {
this.parentTypes = parentTypes;
}
+ private HierarchyMatch(String[] parentTypes, boolean interfaceOnlyMatch) {
+ this(parentTypes);
+ this.interfaceOnlyMatch = interfaceOnlyMatch;
+ }
+
Review comment:
If an interface extends, then what? You can't intercept an interface,
because nothing invoked there. Wha is your point? And what is instrumentation
for interface only meaning? How to enhance an interface?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
