arugal commented on a change in pull request #4172: Provide profile task
downstream to sniffer
URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041057
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -118,6 +118,11 @@
* Limit the length of the operationName to prevent errors when
inserting elasticsearch
**/
public static int OPERATION_NAME_THRESHOLD = 500;
+
+ /**
+ * If true, skywalking agent will enable profile when user create a
new profile task
+ */
+ public static boolean ACTIVE_PROFILE = false;
Review comment:
> As a key feature of 7.0.0, this flag should be `true` as default. @arugal
Could you share your concern?
1. I think thread monitoring is an auxiliary function
1. Thread snapshot collection has a great impact on application performance
So I think it should be enabled by the user display
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
