wu-sheng commented on a change in pull request #4172: Provide profile task
downstream to sniffer
URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041855
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -118,6 +118,11 @@
* Limit the length of the operationName to prevent errors when
inserting elasticsearch
**/
public static int OPERATION_NAME_THRESHOLD = 500;
+
+ /**
+ * If true, skywalking agent will enable profile when user create a
new profile task
+ */
+ public static boolean ACTIVE_PROFILE = false;
Review comment:
That is why we set the acceptable task with the following limitations
1. Only one endpoint at a certain time.
1. 15 mins as max duration of the task
1. dumpPeriod >= 10ms
1. minDurationThreshold for collecting thread dump in meaningful case.
1. maxSamplingCount should less than 10. FYI @mrproliu I think
`maxSamplingCount` is missing from existing codes, backend and protocol. right?
Please fix this.
We should not set that in the false, because once the undetected performance
issue happens, you have no change to reboot agent already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
