wu-sheng commented on a change in pull request #4236: Optimize the
elasticsearch-based query interface provided to UI
URL: https://github.com/apache/skywalking/pull/4236#discussion_r366765622
##########
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -404,4 +434,65 @@ public String formatIndexName(String indexName) {
}
return indexName;
}
+
+ private String[] formatIndexNames(String indexName, long startTimestamp,
long endTimestamp, String traceId) throws IOException {
Review comment:
Why include `traceId`? TraceId generation rule is only suitable in Java
codebase. We shouldn't count on it at any time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
