wu-sheng commented on a change in pull request #4236: Optimize the
elasticsearch-based query interface provided to UI
URL: https://github.com/apache/skywalking/pull/4236#discussion_r366777682
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java
##########
@@ -216,4 +216,59 @@ private DateTime parseToDateTime(Downsampling
downsampling, long time) throws Pa
return dateTime;
}
+
+ public long convertBucketTotIimestamp(boolean isStart, long bucket) throws
ParseException {
+ String bucketStr = String.valueOf(bucket);
+ if (bucketStr.length() < 14) {
Review comment:
Still not following. Timebucket always could be determined by length, why
separate by 14?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
