wu-sheng commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r366854851
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java
##########
@@ -497,6 +510,11 @@ private void finish() {
TracingContext.ListenerManager.notifyFinish(finishedSegment);
running = false;
+
+ /**
+ * Notify current tracing context main thread has already
execute finished.
Review comment:
This notification should not be in `(!isRunningInAsyncMode ||
asyncSpanCounter.get() == 0))`. The condition means async finished. You just
need `activeSpanStack.isEmpty() && running`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
