wu-sheng commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r367266011
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/AbstractTracingSpan.java
##########
@@ -203,6 +203,9 @@ public AbstractTracingSpan errorOccurred() {
public AbstractTracingSpan setOperationName(String operationName) {
this.operationName = operationName;
this.operationId = DictionaryUtil.nullValue();
+
+ // recheck profiling status
+ ContextManager.profilingRecheck(this, operationName);
Review comment:
I think we don't need `ContextManager#profilingRecheck`. There is a ref of
`tracingContext` in the span, check `AbstractTracingSpan`. You should use it,
it is better to keep `profilingRecheck` in private, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
