wu-sheng commented on issue #4247: fix thread unsafe problem in server-alarm-plugin (#4230) URL: https://github.com/apache/skywalking/pull/4247#issuecomment-575053184 Two suggestions. 1. `#add` should not include `#moveTo`, as in `#in`, we move the time window first, then call add. 1. This method should only be called by a single thread. So basically, no concurrency access. This lock is for fail-safe. Could you follow these to update this PR?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
