wu-sheng commented on a change in pull request #4247: fix thread unsafe problem
in server-alarm-plugin (#4230)
URL: https://github.com/apache/skywalking/pull/4247#discussion_r368267794
##########
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
##########
@@ -187,7 +182,7 @@ public void moveTo(LocalDateTime targetTime) {
private int silenceCountdown;
private LinkedList<Metrics> values;
- private ReentrantLock lock = new ReentrantLock();
+ private ReentrantLock reentrantLock = new ReentrantLock();
Review comment:
Why change this name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
