wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368211090
##########
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/NotifyHandler.java
##########
@@ -82,6 +82,12 @@ public NotifyHandler(AlarmRulesWatcher alarmRulesWatcher) {
endpointMetaInAlarm.setName(textName);
metaInAlarm = endpointMetaInAlarm;
+ } else if (DefaultScopeDefine.inServicePageCatalog(scope)) {
+ // TODO handler service page path catalog
+ return;
+ } else if (DefaultScopeDefine.inServiceVersionCatalog(scope)) {
+ // TODO handler service version page path catalog
Review comment:
If these are TODOs, why add this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
