wu-sheng commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368230557
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/DefaultScopeDefine.java
##########
@@ -71,16 +71,28 @@
public static final int PROFILE_TASK_LOG = 27;
public static final int PROFILE_TASK_SEGMENT_SNAPSHOT = 28;
+ // browser
+ public static final int BROWSER_PERF_DATA = 40;
+ public static final int SERVICE_PERF_DETAIL = 41;
+ public static final int SERVICE_PAGE_PATH_PERF_DETAIL = 42;
+ public static final int SERVICE_VERSION_PERF_DETAIL = 43;
+ public static final int SERVICE_VERSION_PAGE_PATH_PERF_DETAIL = 44;
Review comment:
`SERVICE_` should be renamed to `BROWSER_`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
