wu-sheng commented on a change in pull request #4264: Refactor
SnifferConfigInitializer and related componets with new features in JDK8+
URL: https://github.com/apache/skywalking/pull/4264#discussion_r368279843
##########
File path: apm-sniffer/apm-agent-core/pom.xml
##########
@@ -126,6 +131,12 @@
<artifactId>guava</artifactId>
<version>${guava.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>${lombok.version}</version>
+ <scope>provided</scope>
Review comment:
My points are two
1. Version should be managed at root pom, as Lombok is used at backend and
agent.
1. With this feature added, a lot of codes could be removed at the agent
side. It should be placed in another PR, with more codes changed. This will
make the changelog clear when I do release several months later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
