wu-sheng commented on a change in pull request #4264: Refactor
SnifferConfigInitializer and related componets with new features in JDK8+
URL: https://github.com/apache/skywalking/pull/4264#discussion_r368290778
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.java
##########
@@ -78,6 +78,7 @@ private static File findPath() throws
AgentPackageNotFoundException {
}
}
+ // TODO No need to log this error message, the exception will be
caught finally
Review comment:
You could delete this log too. Don't leave TODO unless it is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
