dmsolr commented on a change in pull request #4292: Improve ES query performance
URL: https://github.com/apache/skywalking/pull/4292#discussion_r372480002
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/AggregationQueryEsDAO.java
##########
@@ -96,7 +96,7 @@ public AggregationQueryEsDAO(ElasticSearchClient client) {
SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource();
BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
- sourceBuilder.query(boolQueryBuilder);
+
sourceBuilder.query(QueryBuilders.boolQuery().filter(boolQueryBuilder));
boolQueryBuilder.must().add(QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).lte(endTB).gte(startTB));
boolQueryBuilder.must().add(QueryBuilders.termQuery(EndpointInventory.SERVICE_ID,
serviceId));
Review comment:
I am not familiar with ES, but I am very familiar with Lucene.
Something likes TimeRange used `filter` is OK. The query clause will be
cached. But something likes ServiceID, I think it is not suitable.
Please recheck. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
