wu-sheng commented on a change in pull request #4292: Improve ES query
performance
URL: https://github.com/apache/skywalking/pull/4292#discussion_r372845626
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/AggregationQueryEsDAO.java
##########
@@ -96,7 +96,7 @@ public AggregationQueryEsDAO(ElasticSearchClient client) {
SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource();
BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery();
- sourceBuilder.query(boolQueryBuilder);
+
sourceBuilder.query(QueryBuilders.boolQuery().filter(boolQueryBuilder));
boolQueryBuilder.must().add(QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).lte(endTB).gte(startTB));
boolQueryBuilder.must().add(QueryBuilders.termQuery(EndpointInventory.SERVICE_ID,
serviceId));
Review comment:
> However, it should be sure at present that most of the ES queries in SW
should hit yes or no.
Yes. The score is not important for us. We use ES like normal storage,
rather than a search engine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
