kezhenxu94 commented on a change in pull request #4308: provide thread stack analyzes URL: https://github.com/apache/skywalking/pull/4308#discussion_r373834506
########## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStack.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.profile.analyze; + +import com.google.common.primitives.Ints; +import com.google.protobuf.InvalidProtocolBufferException; +import lombok.Data; +import org.apache.skywalking.apm.network.language.profile.ThreadStack; +import org.apache.skywalking.oap.server.core.profile.ProfileTaskSegmentSnapshotRecord; + +import java.util.List; + +/** + * Deserialize from {@link ProfileTaskSegmentSnapshotRecord} + * + * @author MrPro + */ +@Data +public class ProfileStack implements Comparable<ProfileStack> { + + private int sequence; + private long dumpTime; + private List<String> stack; + + public static ProfileStack deserialize(ProfileTaskSegmentSnapshotRecord record) { + ThreadStack threadStack = null; + try { + threadStack = ThreadStack.parseFrom(record.getStackBinary()); + } catch (InvalidProtocolBufferException e) { + new IllegalArgumentException("wrong stack data"); Review comment: ```suggestion throw new IllegalArgumentException("wrong stack data"); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
