kezhenxu94 commented on a change in pull request #4308: provide thread stack analyzes URL: https://github.com/apache/skywalking/pull/4308#discussion_r373834816
########## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.java ########## @@ -0,0 +1,251 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.core.profile.analyze; + +import com.google.common.base.Objects; +import org.apache.skywalking.oap.server.core.query.entity.ProfileStackElement; + +import java.util.Collections; +import java.util.LinkedList; +import java.util.List; +import java.util.ListIterator; +import java.util.stream.Collectors; + +/** + * Work for profiling stacks, intermediate state of the {@link ProfileStackElement} and {@link ProfileStack} + * + * @author MrPro + */ +public class ProfileStackNode { + + // stack code signature + private String codeSignature; + // owner list + private List<ProfileStack> owners; + // children nodes + private List<ProfileStackNode> childes; + // include the execution time of children + private int duration; + + /** + * create new empty, un-init node + * @return + */ + public static ProfileStackNode createEmptyNode() { + ProfileStackNode emptyNode = new ProfileStackNode(); + emptyNode.owners = new LinkedList<>(); + emptyNode.childes = new LinkedList<>(); + return emptyNode; + } + + /** + * accumulate {@link ProfileStack} to this tree, it will invoke on the tree root node + * @param stack + */ + public void accumulateFrom(ProfileStack stack) { + List<String> stackList = stack.getStack(); + if (codeSignature == null) { + codeSignature = stackList.get(0); + } + // increase self + this.increase(stack); + + // handle stack children + ProfileStackNode parent = this; + for (int childDepth = 1; childDepth < stackList.size(); childDepth++) { + String elementCodeSign = stackList.get(childDepth); + + // find same code signature children + ProfileStackNode childElement = null; + for (ProfileStackNode child : parent.childes) { + if (Objects.equal(child.codeSignature, elementCodeSign)) { + childElement = child; + break; + } + } + + if (childElement != null) { + // increase child node + childElement.increase(stack); + parent = childElement; + } else { + // add children + ProfileStackNode childNode = createEmptyNode(); + childNode.codeSignature = elementCodeSign; + childNode.increase(stack); + + parent.childes.add(childNode); + parent = childNode; + } + } + } + + /** + * combine from other {@link ProfileStackNode} + * @param node + * @return + */ + public ProfileStackNode combine(ProfileStackNode node) { + // combine this node + this.combineThisNode(node); + + // merge tree using pre order + LinkedList<Pair<ProfileStackNode, List<ProfileStackNode>>> stack = new LinkedList<>(); + stack.add(new Pair<>(this, node.childes)); + while (!stack.isEmpty()) { + Pair<ProfileStackNode, List<ProfileStackNode>> needCombineNode = stack.pop(); + ProfileStackNode combineTo = needCombineNode.key; + + // merge node + for (ProfileStackNode needCombineChildren : needCombineNode.value) { + boolean sameReference = false; + // find node + ProfileStackNode combinedNode = null; + for (ProfileStackNode combineNodeChildren : combineTo.childes) { + // same code signature + if (Objects.equal(needCombineChildren.codeSignature, combineNodeChildren.codeSignature)) { + // if same reference, dont need to combine anymore + if (needCombineChildren == combineNodeChildren) { + sameReference = true; + } else { + combineNodeChildren.combineThisNode(needCombineChildren); + } + combinedNode = combineNodeChildren; + break; + } + } + + if (combinedNode == null) { + combineTo.childes.add(needCombineChildren); + combinedNode = needCombineChildren; + } + + if (!sameReference) { + stack.add(new Pair(combinedNode, needCombineChildren.childes)); + } + } Review comment: too many nested blocks, better to refactor/extract some short methods ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
