Fine0830 commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581249704 > The metrics summary by review comments. > > ``` > // browser app > browser_app_pv > browser_app_error_rate > browser_app_error_sum > > // browser app single version > browser_app_single_version_page_pv > browser_app_single_version_page_error_rate > > // browser app page > browser_app_page_pv > browser_app_page_error_rate > browser_app_page_error_sum > > browser_app_page_ajax_error_sum > browsre_app_page_resource_error_sum > browsre_app_page_vue_error_sum > browsre_app_page_promise_error_sum > browser_app_page_js_error_sum > browser_app_page_unknown_error_sum > > browser_app_page_redirect_avg > browser_app_page_dns_avg > browser_app_page_req_avg > browser_app_page_dom_analysis_avg > browser_app_page_dom_ready_avg > browser_app_page_blank_avg > > browser_app_page_redirect_percentile > browser_app_page_dns_percentile > browser_app_page_req_percentile > browser_app_page_dom_analysis_percentile > browser_app_page_dom_ready_percentile > browser_app_page_blank_percentile > ``` > > > We should add error rate ranking for versions in service. > > The sort will be implemented in the `query-plugin`. > > > We need to sort errors and calculate errors sum for different catalogs. > > Please provide all known value for the `BrowserErrorLog#catalog` @Fine0830 . I suggest to change the [BrowserErrorLog#catalog](https://github.com/apache/skywalking-data-collect-protocol/blob/eebd016e32b0808416923acf04dcd31d9eb86c09/browser/BrowserPerf.proto#L49) to an enum. > > @wu-sheng @Fine0830 Please confirm :) good to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
