wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r376380061
########## File path: oap-server/oal-grammar/src/main/antlr4/org/apache/skywalking/oal/rt/grammar/OALLexer.g4 ########## @@ -45,10 +45,11 @@ SRC_SERVICE_INSTANCE_CLR_THREAD: 'ServiceInstanceCLRThread'; SRC_ENVOY_INSTANCE_METRIC: 'EnvoyInstanceMetric'; // Browser keywords -SRC_BROWSER_PERF_DETAIL: 'BrowserPerfDetail'; -SRC_BROWSER_PAGE_PATH_PERF_DETAIL: 'BrowserPagePathPerfDetail'; -SRC_BROWSER_SINGLE_VERSION_PERF_DETAIL: 'BrowserSingleVersionPerfDetail'; -SRC_BROWSER_SINGLE_VERSION_PAGE_PATH_PERF_DETAIL: 'BrowserSingleVersionPagePathPerfDetail'; +SRC_BROWSER_APP_PERF: 'BrowserAppPerf'; +SRC_BROWSER_APP_PAGE_PERF: 'BrowserAppPagePerf'; +SRC_BROWSER_APP_SINGLE_VERSION_PERF: 'BrowserAppSingleVersionPerf'; +SRC_BROWSER_APP_ERROR_LOG: 'BrowserAppErrorLog'; +SRC_BROWSER_APP_PAGE_ERROR_LOG: 'BrowserAppPageErrorLog'; Review comment: What is this? I think `SRC_BROWSER_APP_ERROR_LOG` should represent the error log? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
