arugal commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375086744
##########
File path: browser/BrowserPerf.proto
##########
@@ -25,36 +25,56 @@ import "common/common.proto";
// Collect performance raw data from browser.
service BrowserPerfService {
- rpc collect (stream BrowserPerfData) returns (Commands) {
+
+ // report once per page
+ rpc collectPerfData (BrowserPerfData) returns (Commands) {
+ }
+
+ // report one or more error logs for pages, could report multiple times.
+ rpc collectErrorLogs (stream BrowserErrorLog) returns (Commands) {
}
}
message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Perf data time
+ int64 time = 3;
Review comment:
`time` and `pagePathId` need to be used in `browser-receiver`, please keep
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
