Fine0830 commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375086868
##########
File path: browser/BrowserPerf.proto
##########
@@ -25,36 +25,56 @@ import "common/common.proto";
// Collect performance raw data from browser.
service BrowserPerfService {
- rpc collect (stream BrowserPerfData) returns (Commands) {
+
+ // report once per page
+ rpc collectPerfData (BrowserPerfData) returns (Commands) {
+ }
+
+ // report one or more error logs for pages, could report multiple times.
+ rpc collectErrorLogs (stream BrowserErrorLog) returns (Commands) {
}
}
message BrowserPerfData {
+ int32 serviceId = 1;
+ // Service version in browser is the Instance concept in the backend.
+ int32 serviceVersionId = 2;
+ // Perf data time
+ int64 time = 3;
+ // Page path in browser is the endpoint concept in the backend
+ // Page path in the browser, mostly it is URI, without parameter
+ string pagePath = 4;
+ int32 pagePathId = 5;
+ // Unit of all time related field should be `ms`.
+ int32 redirectTime = 6;
+ int32 dnsTime = 7;
+ int32 reqTime = 8;
+ // analysis dom tree time
+ int32 domAnalysisTime = 9;
+ int32 domReadyTime = 10;
+ // page blank time
+ int32 blankTime = 11;
+}
+
+message BrowserErrorLog {
// UUID
string uniqueId = 1;
int32 serviceId = 2;
// Service version in browser is the Instance concept in the backend.
int32 serviceVersionId = 3;
- // Data time
+ // Error log time
int64 time = 4;
Review comment:
As above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
