wu-sheng commented on a change in pull request #4337: Review code styles
automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785766
##########
File path: .github/workflows/ci-it.yaml
##########
@@ -38,11 +38,26 @@ jobs:
- uses: actions/setup-java@v1
with:
java-version: 8
+
+ - name: Setup reviewdog
+ run: |
+ mkdir -p $HOME/bin && curl -sfL
https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh| sh -s
-- -b $HOME/bin
+ echo ::add-path::$HOME/bin
+ echo ::add-path::$(go env GOPATH)/bin # for Go projects
+
- name: 'Install & Test'
run: |
export MAVEN_OPTS='-XX:+TieredCompilation -XX:TieredStopAtLevel=1
-XX:+CMSClassUnloadingEnabled -XX:+UseConcMarkSweepGC -XX:-UseGCOverheadLimit
-Xmx3g'
./mvnw --batch-mode -P"agent,backend,ui,dist,CI-with-IT" clean
cobertura:cobertura verify install javadoc:javadoc
CODECOV_TOKEN="d2065307-8f01-4637-9715-2781ef096db7" bash <(curl -s
https://codecov.io/bash)
+
+ - name: Run reviewdog
+ env:
+ REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ run: |
+ ./mvnw clean -Dcheckstyle.fails.on.error=false
checkstyle:checkstyle-aggregate
Review comment:
Does this gets any chance to run? If checkstyle fail, the `Install & Test`
step should stop the CI, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
